Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using __align__ in ROCm #2638

Merged
merged 1 commit into from Nov 20, 2019
Merged

Avoid using __align__ in ROCm #2638

merged 1 commit into from Nov 20, 2019

Conversation

kmaehashi
Copy link
Member

Ref #2562

@kmaehashi kmaehashi added the cat:bug Bugs label Nov 13, 2019
@leofang
Copy link
Member

leofang commented Nov 13, 2019

Geez...I wonder if the template complex_storage in the latest Thrust would work with ROCm? If so, we get another incentive for resolving #2629 and then revisit the alignment issue...

@kmaehashi
Copy link
Member Author

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a5c754c:

leofang
leofang reviewed Nov 13, 2019
View reviewed changes
cupy/core/include/cupy/complex/complex.h
@@ -62,7 +62,12 @@ struct _select_greater_type
*
*/
template <typename T>
#if defined(__CUDACC__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test __CUDACC_RDC__ here? It's a preparation for #2426.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both __CUDACC__ and __CUDACC_RDC__ are set when built with --relocatable-device-code=true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! Yes, I can verify. Thanks @kmaehashi! This is not obvious from the documentation...☹️

@Crissman
Copy link
Member

imosCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a5c754c:

@Crissman
Copy link
Member

imosCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a5c754c:

@kmaehashi
Copy link
Member Author

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a5c754c:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit a5c754c, target branch master) succeeded!

@Crissman Crissman merged commit 48518bb into cupy:master Nov 20, 2019
@kmaehashi kmaehashi deleted the improve-rocm-errors branch November 20, 2019 10:22
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

Assignees

@Crissman Crissman

Labels
cat:bug Bugs
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kmaehashi @leofang @pfn-ci-bot @Crissman @chainer-ci