Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory allocation in set_contiguous_strides #2690

Merged
merged 1 commit into from Nov 26, 2019

Conversation

okuta
Copy link
Member

@okuta okuta commented Nov 24, 2019

vector.vector[Py_ssize_t] allocation is slow.

@okuta
Copy link
Member Author

okuta commented Nov 24, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 81fec8c:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 81fec8c, target branch master) succeeded!

@niboshi niboshi assigned niboshi and emcastillo and unassigned niboshi Nov 26, 2019
@emcastillo emcastillo added the cat:performance Performance in terms of speed or memory consumption label Nov 26, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Nov 26, 2019
@emcastillo
Copy link
Member

Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 81fec8c:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 81fec8c, target branch master) succeeded!

@emcastillo emcastillo merged commit 5b06e23 into cupy:master Nov 26, 2019
@okuta okuta deleted the improve-set_contiguous_strides branch December 2, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:performance Performance in terms of speed or memory consumption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants