Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that segfault when using SciPy 1.3.x #2712

Merged
merged 3 commits into from Nov 27, 2019

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 25, 2019

Avoid two tests that segfault within SciPy when it is version 1.3.* (or 1.4.0rc1). See scipy/scipy#11125.

Hopefully this will be fixed prior to the final 1.4.0 release.

@niboshi
Copy link
Member

niboshi commented Nov 26, 2019

Thanks. Could you add a link to scipy/scipy#11125 to each test?

@niboshi niboshi self-assigned this Nov 26, 2019
@niboshi niboshi added cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch labels Nov 26, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 26, 2019
@niboshi
Copy link
Member

niboshi commented Nov 26, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 7a64b27:

@niboshi niboshi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Nov 26, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7a64b27, target branch master) failed with status FAILURE.

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 26, 2019

sorry about the typo in with_requires. I have verified that the tests pass locally now.

@niboshi
Copy link
Member

niboshi commented Nov 27, 2019

NP! Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 1760cda:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1760cda, target branch master) succeeded!

@niboshi niboshi merged commit 86c58ca into cupy:master Nov 27, 2019
niboshi added a commit to niboshi/cupy that referenced this pull request Nov 27, 2019
Skip tests that segfault when using SciPy 1.3.x
@grlee77 grlee77 deleted the avoid_scipy_segfault branch September 9, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test code / CI st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants