Detect interpreter shutdown for proper __del__ behavior
#2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
force-pushed
the
fix_shutdown
branch
2 times, most recently
from
298195a
to
77a558e
Compare
|
A nitpick but how about this way? if is_shutting_down():
returnNo extra indentation needed, not complicating conditions, and you can write the same way for any clean up code. |
toslunar
reviewed
Dec 13, 2019
emcastillo
force-pushed
the
fix_shutdown
branch
from
77a558e
to
3ef0d3b
Compare
|
Thanks for comments. |
|
LGTM |
|
Successfully created a job for commit 3ef0d3b: |
|
Jenkins CI test (for commit 3ef0d3b, target branch master) succeeded! |
niboshi
added
cat:bug
This was referenced Dec 13, 2019
Closed
niboshi
added a commit
to niboshi/cupy
that referenced
this pull request
Dec 13, 2019
Detect interpreter shutdown for proper `__del__` behavior
This was referenced Dec 13, 2019
niboshi
added a commit
to niboshi/cupy
that referenced
this pull request
Dec 13, 2019
Detect interpreter shutdown for proper `__del__` behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2806, #2658, and #2777
In some python interpreters (mostly installed with pyenv)
The following one-liner causes an exception in object destruction during interpreter shutdown.
python -c 'import cupy; stream = cupy.cuda.Stream()'When finishing program execution, python does not guarantee the order in which objects are destroyed.
Calls inside a del method calling other objects or modules are not guaranteed to be correctly executed as those objects can be already deleted.
PEP442 should address this, but we have seen this problem persists.
This solution is obtained from Numba/llvmlite code.