Add convex analysis ufuncs to cupyx.scipy.special
#2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
changed the title
cupyx.scipy.special
niboshi
requested changes
Dec 25, 2019
tests/cupyx_tests/scipy_tests/special_tests/test_convex_analysis.py
Outdated
Show resolved
Hide resolved
tests/cupyx_tests/scipy_tests/special_tests/test_convex_analysis.py
Outdated
Show resolved
Hide resolved
tests/cupyx_tests/scipy_tests/special_tests/test_convex_analysis.py
Outdated
Show resolved
Hide resolved
tests/cupyx_tests/scipy_tests/special_tests/test_convex_analysis.py
Outdated
Show resolved
Hide resolved
|
Thanks for the nice review and sorry about all the minor formatting issues in the C++ source! I have addressed them now. |
|
ping. this should be ready for testing |
|
Sorry for delay. |
|
Successfully created a job for commit 45bc4e8: |
|
Jenkins CI test (for commit 45bc4e8, target branch master) failed with status FAILURE. |
|
I have moved the import that was causing 1 CI failure. please try again |
|
Thanks. Jenkins, test this please |
|
Successfully created a job for commit 4bc7ee1: |
|
Jenkins CI test (for commit 4bc7ee1, target branch master) succeeded! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds five simple ufuncs to
cupyx.scipy.special. In SciPy, these are defined in _convex_analysis.pxd. I followed some existing examples in the cupyx.scipy.special folder on how to handle NaN's and added an equivalent handling for INF values here.entrandrel_entrare used to implementscipy.stats.entropyif there is interest in adding that in a follow-up PR.Most of the test cases added here correspond to ones defined in the SciPy test suite.