Getitem for major dimension #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2017
Closed
unnonouno
force-pushed
the
getitem-major-slice
branch
2 times, most recently
from
734811b
to
083597e
Compare
|
LGTM, will be merged after #240! |
unnonouno
force-pushed
the
getitem-major-slice
branch
from
083597e
to
4e75e92
Compare
|
I fixed behavior of getitem for slices with negative values. |
takagi
requested changes
Jul 30, 2017
cupy/sparse/compressed.py
Outdated
| major_stop = major_size | ||
| if major_step is None: | ||
| major_step = 1 | ||
| print(major_start, major_stop, major_size) |
takagi
approved these changes
Aug 1, 2017
|
Please resolve the conflicts. |
unnonouno
force-pushed
the
getitem-major-slice
branch
from
9099404
to
906e241
Compare
|
I rebased master. |
|
I will merge this after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented getitem for major dimension of compressed matrixes.
Please merge #240 first.
related to #36