Array conversion from dia_matrix #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
unnonouno
force-pushed
the
dia-array-conversion
branch
from
f4ce630
to
e3a989a
Compare
takagi
requested changes
Aug 9, 2017
cupy/sparse/dia.py
Outdated
| return int(nnz) | ||
|
|
||
| def toarray(self, order=None, out=None): | ||
| """Return a dense ndarray representation of this matrix.""" |
There was a problem hiding this comment.
One-line docstring is enough, though it would be better to describe in the same expression to other formats as
Returns a dense matrix representing the same value.
https://github.com/cupy/cupy/blob/master/cupy/sparse/csr.py#L157.
|
Please resolve the conflicts. |
unnonouno
force-pushed
the
dia-array-conversion
branch
from
e3a989a
to
8305116
Compare
takagi
approved these changes
Aug 9, 2017
|
jenkins, test this please |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented array conversion method for dia_matrix.
Merge #320 first.
Related to #36