Fix put when using scalars
#3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
changed the title
put when using scalarsput when using scalars
takagi
added
cat:bug
|
LGTM! |
|
pfnCI, test this please. |
|
Successfully created a job for commit 1ea729b: |
|
Jenkins CI test (for commit 1ea729b, target branch master) succeeded! |
takagi
added a commit
to takagi/cupy
that referenced
this pull request
May 12, 2020
Fix `put` when using scalars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3325
When using scalars calling put,
ndarrayis called, butndarraytakes the shape as parameter instead of the actual data,creating incorrect arrays.