Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SCM version to indicate development versions #3478

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Use SCM version to indicate development versions #3478

wants to merge 6 commits into from

Conversation

kmaehashi
Copy link
Member

When version is v8.0.0b3:

$ python setup.py --version
8.0.0b4.dev393+g6ddaac33e

@leofang
Copy link
Member

leofang commented Jun 24, 2020

Just curious, do you know what's the difference between SCM and versioneer's approaches?

@kmaehashi kmaehashi added the cat:install Build and installation label Jun 25, 2020
@kmaehashi kmaehashi added this to the v8.0.0b5 milestone Jun 25, 2020
@emcastillo emcastillo modified the milestone: v8.0.0b5 Jun 25, 2020
@leofang
Copy link
Member

leofang commented Jun 25, 2020

I found some projects are moving away from versioneer to SCM: pytroll/satpy#678

@kmaehashi
Copy link
Member Author

Actually I haven't ever used both 😅
AFAIK versioneer is feature-richer than setuptools_scm but needs to be included in the repository and seems not maintained well recently. setuptools_scm is pypa's project (ie it's semi-official) and seems enough for us.

@leofang
Copy link
Member

leofang commented Jun 26, 2020 •
edited

Yeah the major concern for versioneer is it's no longer actively maintained... On the other hand, a valid argument is if it's included in the repo and it's working fine, it should not be maintained by upstream 😂 Anyway SCM is new and I'm happy to learn there's a semi-official solution that could replace versioneer.

@emcastillo emcastillo changed the title [WIP] Use SCM version to indicate development versions SCM to indicate development versions [WIP] Use SCM version to indicate development versions Jul 6, 2020
@kmaehashi kmaehashi added the blocking Issue/pull-request is mandatory for the upcoming release label Jul 21, 2020
@asi1024 asi1024 removed this from the v8.0.0b5 milestone Jul 29, 2020
@kmaehashi kmaehashi removed the blocking Issue/pull-request is mandatory for the upcoming release label Aug 24, 2020
@kmaehashi
Copy link
Member Author

TODO: think about release sdist/wheel which is built before tagging at repo. Maybe add --cupy-version x.y.z option to override SCM version?

@leofang
Copy link
Member

leofang commented Aug 24, 2020

I am curious, does SCM respect cupy/_version.py?

@kmaehashi kmaehashi changed the title [WIP] Use SCM version to indicate development versions Use SCM version to indicate development versions Oct 27, 2020
@emcastillo
Copy link
Member

Let's fix the conflict :(

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e0c2241, target branch master) failed with status FAILURE.

@emcastillo
Copy link
Member 

raise RuntimeError('version information is not fouond: %s' % setup_path)

@emcastillo emcastillo added the st:awaiting-author Awaiting response from author label Nov 18, 2020
@emcastillo
Copy link
Member

seems like rtd is broken :(

ImportError: 
Error importing CuPy: version information could not be found.

It is likely that you are trying to import cupy from its source directory without building it;
please exit the cupy source tree, and relaunch your python interpreter from there.

@emcastillo
Copy link
Member

It seems to be working after adding the missing setuptools_scm package to the requirements for regular pip install and read the docs.

  • I am not sure if setuptools_scm should be an install dependence, as sdist and the wheels will use the already bundled VERSION file. However it is needed for development and CIs.

Should we just do like we did with Cython, not add it as a dependence for other than CIs and modify the error message to let developers know that they need to install it.?

@kmaehashi
Copy link
Member Author

pfnCI, test this please.

@kmaehashi
Copy link
Member Author

pfnCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0412757, target branch master) failed with status FAILURE.

@kmaehashi
Copy link
Member Author

Blocked by : chainer/chainer-test#636

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added st:test-and-merge (deprecated) Ready to merge after test pass. and removed st:awaiting-author Awaiting response from author labels Feb 24, 2021
@emcastillo emcastillo added this to the v9.0.0b3 milestone Feb 24, 2021
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 98a2b5b, target branch master) failed with status FAILURE.

@emcastillo emcastillo removed this from the v9.0.0b3 milestone Feb 26, 2021
@chainer-ci
Copy link
Member

@emcastillo This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

leofang
leofang suggested changes Mar 4, 2021
View reviewed changes
VERSION
@@ -0,0 +1 @@
v9.0.0b2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be bumped.

@chainer-ci
Copy link
Member

@emcastillo This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@emcastillo emcastillo removed the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 8, 2021
@leofang
Copy link
Member

leofang commented Mar 15, 2021

Looks like Conda-Forge already supports SCM: conda-forge/conda-forge.github.io#1274

@kmaehashi kmaehashi added the st:awaiting-author Awaiting response from author label May 17, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2021

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

3 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2023

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

@kmaehashi kmaehashi marked this pull request as draft June 25, 2023 14:29
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 6, 2024

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

@asi1024 asi1024 assigned asi1024 and unassigned emcastillo Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang requested changes

@emcastillo emcastillo emcastillo approved these changes

Assignees

@asi1024 asi1024

Labels
cat:install Build and installation st:awaiting-author Awaiting response from author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kmaehashi @leofang @emcastillo @chainer-ci @asi1024