Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute import #3496

Merged
merged 1 commit into from Jun 26, 2020
Merged

Use absolute import #3496

merged 1 commit into from Jun 26, 2020

Conversation

takagi
Copy link
Member

@takagi takagi commented Jun 25, 2020

Fix to use absolute import.

@takagi takagi added the cat:code-fix Code refactoring that do not change behavior label Jun 25, 2020
@asi1024 asi1024 added this to the v8.0.0b5 milestone Jun 25, 2020
@asi1024
Copy link
Member

asi1024 commented Jun 25, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 71e3ae8:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 71e3ae8, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member

asi1024 commented Jun 26, 2020

Jenkins failure seems unrelated to this PR. Fixed in #3501.

@asi1024
Copy link
Member

asi1024 commented Jun 26, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 71e3ae8:

@asi1024 asi1024 added the st:test-and-merge (deprecated) Ready to merge after test pass. label Jun 26, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 71e3ae8, target branch master) succeeded!

@asi1024
Copy link
Member

asi1024 commented Jun 26, 2020

LGTM.

@asi1024 asi1024 merged commit 5b20496 into cupy:master Jun 26, 2020
@takagi takagi deleted the sparse-absolute-import branch June 28, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that do not change behavior st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants