[REVIEW] 2D Sparse Slicing + Row & Column Indexing #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2020
…e-slicing_minor_indexing
…e-slicing_minor_indexing
…e-slicing_minor_indexing Conflicts: cupyx/scipy/sparse/compressed.py
…e-slicing_minor_indexing
…e-slicing_minor_indexing Conflicts: tests/cupyx_tests/scipy_tests/sparse_tests/test_index.py
…e-slicing_minor_indexing
…e-slicing_minor_indexing Conflicts: cupyx/scipy/sparse/_index.py
…python list, int32, int64, etc...)
…e-slicing_minor_indexing
|
@asi1024 Just merged master into this branch. This should be ready for review. |
asi1024
reviewed
Aug 20, 2020
| return Bp, Aj_mask, col_counts, sort_idxs | ||
|
|
||
|
|
||
| _csr_column_index2_ker = core.ElementwiseKernel( |
There was a problem hiding this comment.
This kernel looks to work slowly in some cases for the same reasons as #3658 (comment), but it's OK to leave in this PR.
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 5ee4e1f, target branch master) succeeded! |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #3658, adding sparse column indexing.