[backport] support order argument in cupy.ones, cupy.full and cupy.eye #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support order argument in cupy.ones, cupy.full and cupy.eye
takagi
added
backport
|
[automatic post] Jenkins, test this please. |
|
Successfully created a job for commit c53bf90: |
|
Jenkins CI test (for commit c53bf90, target branch v7) failed with status FAILURE. |
|
Seems like it is not working well 😅 |
|
I've fixed that, PTAL! |
|
Jenkins, test this please |
|
Successfully created a job for commit 9c39c76: |
|
Jenkins CI test (for commit 9c39c76, target branch v7) failed with status FAILURE. |
|
I think we may need to skip older numpy for |
|
Jenkins, test this please |
|
Jenkins CI test (for commit b0085d4, target branch v7) failed with status FAILURE. |
leofang
reviewed
Aug 12, 2020
| @@ -161,11 +161,19 @@ def test_empty_zero_sized_array_strides(self, order): | |||
| b = cupy.empty((1, 0, 2), dtype='d', order=order) | |||
| self.assertEqual(b.strides, a.strides) | |||
|
|
|||
| @testing.for_CF_orders() | |||
There was a problem hiding this comment.
This line needs to be removed 😅
|
Jenkins, test this please |
|
Jenkins CI test (for commit d0bb8f1, target branch v7) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3655