Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining greyscale morphology operations to cupyx.scipy.ndimage #3946

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Add remaining greyscale morphology operations to cupyx.scipy.ndimage #3946

merged 4 commits into from
Sep 17, 2020

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Sep 4, 2020 •
edited

This PR adds the four remaining greyscale morphology functions: morphological_gradient, morphological_laplace, white_tophat, black_tophat. In combination with gh-3907, this completes CuPy's coverage of scipy.ndimage.morphology module with the exception of distance_transform_*.

The implementations here are simple as they just rely on the existing grey_erosion and grey_dilation functions.

@emcastillo emcastillo self-assigned this Sep 7, 2020
@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added the cat:feature New features/APIs label Sep 17, 2020
@emcastillo emcastillo changed the title add remaining greyscale morphology operations to cupyx.scipy.ndimage Add remaining greyscale morphology operations to cupyx.scipy.ndimage Sep 17, 2020
@emcastillo emcastillo added this to the v9.0.0a1 milestone Sep 17, 2020
@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Sep 17, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4f69ed3, target branch master) failed with status FAILURE.

@emcastillo
Copy link
Member

Check Jenkins error please 😇

@grlee77
Copy link
Contributor Author

grlee77 commented Sep 17, 2020 •
edited

Check Jenkins error please

There is a single parameterized case failing for a binary erosion/dilation test case unrelated to this PR. Oddly enough, we did see one failure case (although a different one) there as well when @jakirkham first ran the tests in #3907, but it was not reproducible and went away when the CI was re-run.

@jakirkham
Copy link
Member

jakirkham commented Sep 17, 2020 •
edited

Sure let's try again. Though the fact that there is a reoccurring sporadic test failure is a bit worrying.

Jenkins, test this please.

@grlee77
Copy link
Contributor Author

grlee77 commented Sep 17, 2020 •
edited

Sure let's try again. Though the fact that there is a reoccurring sporadic test failure is a bit worrying.

Agreed, but it is going to be difficult to diagnose if we can't reproduce it! (I have never seen it occur locally)

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4f69ed3, target branch master) succeeded!

@mergify mergify bot merged commit dbb7cb0 into cupy:master Sep 17, 2020
@jakirkham
Copy link
Member

Should we file an issue to track it?

@grlee77 grlee77 deleted the ndimage_gray_morphology branch December 18, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcastillo emcastillo emcastillo approved these changes

Assignees

@emcastillo emcastillo

Labels
cat:feature New features/APIs prio:medium st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Milestone
v9.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grlee77 @emcastillo @chainer-ci @jakirkham