New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement spmatrix that is a base class of sparse matrixes #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add scipy
to test dependency.
return bool(s) | ||
|
||
@testing.numpy_cupy_raises(sp_name='sp', accept_error=ValueError) | ||
def test_bool_true(self, xp, sp): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two test_bool_true
. Please rename.
Please add |
Ah, scipy support is optional. So, i'll make the test optional. |
LGTM! And, please send a PR to chaienr-test. |
I implemented spmatrix that is a base class of all other sparse matrixes. It is compatible with
scipy.sparse.spmatrix
.related to #36
merge #39 before this PR.