Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix managed memory leak #4015

Merged
merged 1 commit into from Sep 29, 2020
Merged

Fix managed memory leak #4015

merged 1 commit into from Sep 29, 2020

Conversation

leofang
Copy link
Member

@leofang leofang commented Sep 21, 2020

Looks like the managed memory is not freed even after free_all_blocks() is called, see https://stackoverflow.com/q/63998616/2344149. I checked this PR is in effect by monitoring top and nvidia-smi.

@leofang
Copy link
Member Author

leofang commented Sep 21, 2020

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 91f824d, target branch master) succeeded!

@kmaehashi kmaehashi self-assigned this Sep 23, 2020
@kmaehashi kmaehashi added cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch labels Sep 23, 2020
@kmaehashi kmaehashi added this to the v9.0.0a1 milestone Sep 29, 2020
@kmaehashi kmaehashi merged commit 9f05d49 into cupy:master Sep 29, 2020
@kmaehashi
Copy link
Member

LGTM!

kmaehashi added a commit to kmaehashi/cupy that referenced this pull request Sep 29, 2020
@leofang leofang deleted the managed_free branch September 29, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants