Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cupyx.scipy.ndimage.fourier_ellipsoid #4361

Merged
merged 7 commits into from
Dec 14, 2020

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 30, 2020

This adds the fourier_ellipsoid filter, completing the cupyx.scipy.ndimage.fourier module. Unlike the other Fourier filters, this one is not separable and is not truly n-dimensional (as in SciPy itself, only 1d, 2d and 3d cases are implemented).

@emcastillo emcastillo self-assigned this Nov 30, 2020
@emcastillo emcastillo added this to the v9.0.0b1 milestone Nov 30, 2020
@emcastillo emcastillo added the cat:feature New features/APIs label Nov 30, 2020
@emcastillo
Copy link
Member

TODO: Add to docs

@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Dec 10, 2020
@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7fcd8d2, target branch master) failed with status FAILURE.

@grlee77
Copy link
Contributor Author

grlee77 commented Dec 10, 2020

My apologies, there was a missing scipy import in the test file. It should be fixed now.

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 69ed3aa, target branch master) failed with status FAILURE.

fftpack and ndimage imports should occur in finally clause to work on SciPy < 1.4

AxisError comparisons can only be done on SciPy >= 1.5.0 (it was ValueError in older SciPy)
@grlee77
Copy link
Contributor Author

grlee77 commented Dec 11, 2020

This is ready to try the CI again

I have fixed the tests for the case when SciPy is not available and to account for a change in SciPy error type from ValueError->AxisError in 1.5.

@emcastillo
Copy link
Member

Thanks!

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 53ec841, target branch master) succeeded!

@mergify mergify bot merged commit fa4e436 into cupy:master Dec 14, 2020
@grlee77 grlee77 deleted the fourier_ellipsoid branch December 18, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:feature New features/APIs prio:medium st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants