add cupyx.scipy.ndimage.fourier_ellipsoid #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
force-pushed
the
fourier_ellipsoid
branch
from
8f80bb1
to
231deb8
Compare
emcastillo
approved these changes
Dec 10, 2020
|
TODO: Add to docs |
emcastillo
added
the
st:test-and-merge
|
Jenkins, test this please |
|
Jenkins, test this please |
|
Jenkins CI test (for commit 7fcd8d2, target branch master) failed with status FAILURE. |
|
My apologies, there was a missing scipy import in the test file. It should be fixed now. |
|
Jenkins, test this please |
emcastillo
approved these changes
Dec 11, 2020
|
Jenkins CI test (for commit 69ed3aa, target branch master) failed with status FAILURE. |
fftpack and ndimage imports should occur in finally clause to work on SciPy < 1.4 AxisError comparisons can only be done on SciPy >= 1.5.0 (it was ValueError in older SciPy)
|
This is ready to try the CI again I have fixed the tests for the case when SciPy is not available and to account for a change in SciPy error type from ValueError->AxisError in 1.5. |
|
Thanks! |
|
Jenkins, test this please |
|
Jenkins CI test (for commit 53ec841, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
fourier_ellipsoidfilter, completing thecupyx.scipy.ndimage.fouriermodule. Unlike the other Fourier filters, this one is not separable and is not truly n-dimensional (as in SciPy itself, only 1d, 2d and 3d cases are implemented).