Fix ravel for strides 0
#5978
Merged
Fix ravel for strides 0
#5978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
requested changes
Nov 1, 2021
| if order_char == b'A': | ||
| if self._f_contiguous and not self._c_contiguous: | ||
| order_char = b'F' | ||
| else: | ||
| order_char = b'C' | ||
| if order_char == b'C': | ||
| return _reshape(self, shape) | ||
| return _reshape(self, shape, enforce_copy) |
There was a problem hiding this comment.
The input is copied only if it's required. Maybe it should have been tested that
>>> x = xp.ones((2, 3)); x.ravel().base is x
True
|
yes, |
|
Review comments done! |
|
seems like i rebased something that i shouldn't, will fix |
kmaehashi
added
cat:bug
|
Should be ok now! PTAL :) |
toslunar
requested changes
Nov 4, 2021
Co-authored-by: Toshiki Kataoka <tos.lunar@gmail.com>
Co-authored-by: Toshiki Kataoka <tos.lunar@gmail.com>
|
makes sense, thanks!! |
|
pfnCI, test this please. |
|
Jenkins CI test (for commit 93cfba6, target branch master) succeeded! |
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Nov 4, 2021
Fix `ravel` for strides 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always enforce the copy if the array is neither c- or f-contiguous.
Closes #5972