[backport] Remove XFAIL for XPASS tests on ROCm #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove XFAIL for XPASS tests on ROCm
chainer-ci
added
backport
|
/test mini |
|
I saw the CI result and the tests affected by the change all passed, and failures are not related. Would you merge this, @kmaehashi ? |
|
Thanks for checking CI result, the problem should be resolved once #6303 is backported so let's do it first :) |
|
Okay, I was not aware of it. |
|
/test mini |
takagi
approved these changes
Jan 13, 2022
|
/test mini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6259 by @takagi