Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the warning for cupy.array_api say "cupy" instead of "numpy" #6791

Merged
merged 1 commit into from Jun 20, 2022
Merged

Make the warning for cupy.array_api say "cupy" instead of "numpy" #6791

merged 1 commit into from Jun 20, 2022

Conversation

asmeurer
Copy link
Contributor

There are a lot of other references to "numpy" in the module docstrings, which I did not change, but this one is confusing because it prints to the screen when cupy.array_api is imported.

leofang
leofang approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we kept the "numpy" references around to make it easier to apply patches from NumPy, but I think this PR should be fine. We eventually need to deviate from NumPy when things get more stable.

@kmaehashi kmaehashi self-assigned this Jun 17, 2022
@kmaehashi kmaehashi added cat:enhancement Improvements to existing features prio:medium labels Jun 17, 2022
@kmaehashi
Copy link
Member

/test mini

@kmaehashi kmaehashi added this to the v11.0.0rc1 milestone Jun 20, 2022
@kmaehashi kmaehashi added the to-be-backported Pull-requests to be backported to stable branch label Jun 20, 2022
@kmaehashi kmaehashi merged commit 0ea9f39 into cupy:master Jun 20, 2022
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jun 20, 2022
@kmaehashi @chainer-ci
Merge pull request cupy#6791 from asmeurer/array_api-warning-fix
1421ede 
Make the warning for cupy.array_api say "cupy" instead of "numpy"
@chainer-ci chainer-ci mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

@leofang leofang leofang approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v11.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asmeurer @kmaehashi @leofang