Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA 7.5 nvcc compilation error in string.h #70

Merged
merged 3 commits into from
May 30, 2017
Merged

Fix CUDA 7.5 nvcc compilation error in string.h #70

merged 3 commits into from
May 30, 2017

Conversation

gwtnb
Copy link
Member

@gwtnb gwtnb commented May 30, 2017

@beam2d
Copy link
Contributor

beam2d commented May 30, 2017

Could you write down into the script briefly the reason why this line is needed?

@mitmul
Copy link
Member

mitmul commented May 30, 2017

How about adding this comment right above the inserted line?

# When the gcc version is new, memcpy cannot be found in string.h
# This is a workaround for Ubuntu 16.04 environment with CUDA 7.5

@beam2d
Copy link
Contributor

beam2d commented May 30, 2017

Then why does the issue resolved by adding _FORCE_INLINES macro?

@mitmul
Copy link
Member

mitmul commented May 30, 2017

A known problem with cuda 7.5 on Ubuntu 16.4 is that gcc5.3 does not automatically deal with memcpy as it did in the past. Some people pointed out that the string.h header files are different, that is no longer true. The string.h file is correct if -D_FORCE_INLINES is passed to nvcc.
https://groups.google.com/forum/#!topic/theano-users/3ihQYiTRG4E

Work around a glibc bug
http://www.deeplearning.net/software/theano/install_ubuntu.html

Hmm, I'm not sure what the flag is exactly doing.

@beam2d
Copy link
Contributor

beam2d commented May 30, 2017

It looks better to add a link to that discussion.

@mitmul
Copy link
Member

mitmul commented May 30, 2017

Fixed the comment to make it more detailed and added links to some discussions.

@beam2d beam2d merged commit fe3d200 into master May 30, 2017
@beam2d beam2d deleted the fix-build branch May 30, 2017 02:23
@beam2d
Copy link
Contributor

beam2d commented May 30, 2017

Thank you!

@beam2d beam2d added cat:bug Bugs cat:install Build and installation labels May 30, 2017
@okuta okuta modified the milestone: v1.0.0 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bugs cat:install Build and installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants