Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SciPy 1.10 #7367

Merged
merged 11 commits into from
May 23, 2023
Merged

Support SciPy 1.10 #7367

merged 11 commits into from
May 23, 2023

Conversation

takagi
Copy link
Member

@takagi takagi commented Feb 2, 2023

No description provided.

@takagi
Copy link
Member Author

takagi commented Feb 2, 2023

/test mini

@kmaehashi kmaehashi self-assigned this Feb 3, 2023
@kmaehashi kmaehashi added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch prio:medium labels Feb 3, 2023
@takagi
Copy link
Member Author

takagi commented Feb 8, 2023

/test mini

@takagi
Copy link
Member Author

takagi commented Feb 13, 2023

/test mini

@asi1024 asi1024 mentioned this pull request Feb 13, 2023
Closed
@takagi @asi1024
Update tests/cupyx_tests/scipy_tests/signal_tests/test_signaltools.py
12a7d4b 
Co-authored-by: Akifumi Imanishi <akifumi.imanishi@gmail.com>
@takagi
Copy link
Member Author

takagi commented Feb 13, 2023

/test mini

@takagi
Copy link
Member Author

takagi commented Feb 14, 2023

/test mini

@takagi
Copy link
Member Author

takagi commented Feb 14, 2023 

E           ImportError: Missing optional dependency 'pooch' required for scipy.datasets module. Please use pip or conda to install 'pooch'.

@takagi
Copy link
Member Author

takagi commented Feb 15, 2023

@asi1024 I think we're okay to have pooch in the CI to use scipy.datasets.
https://docs.scipy.org/doc/scipy/reference/datasets.html#how-dataset-retrieval-and-storage-works

The data of scipy.datasets.ascent() seems to be 262KB binary indicated here:

>>> scipy.datasets.ascent()
Downloading file 'ascent.dat' from 'https://raw.githubusercontent.com/scipy/dataset-ascent/main/ascent.dat' to '/home/mtakagi/.cache/scipy-data'.
array([[ 83,  83,  83, ..., 117, 117, 117],
       [ 82,  82,  83, ..., 117, 117, 117],
       [ 80,  81,  83, ..., 117, 117, 117],
       ...,
       [178, 178, 178, ...,  57,  59,  57],
       [178, 178, 178, ...,  56,  57,  57],
       [178, 178, 178, ...,  57,  57,  58]], dtype=uint8)

Any idea?

@kmaehashi
Copy link
Member

IMO we can just use random numbers instead of real image data for convolution tests.

@takagi
Copy link
Member Author

takagi commented Feb 15, 2023

It may work, but what I want to check here is that the testcase is named EdgeCase, so I'm going to see what the data means.

@takagi
Copy link
Member Author

takagi commented Feb 15, 2023

Ah, just a gray scale picture
https://docs.scipy.org/doc/scipy/reference/generated/scipy.datasets.ascent.html

@takagi
Copy link
Member Author

takagi commented Feb 16, 2023

/test mini

@grlee77 grlee77 mentioned this pull request Feb 17, 2023
Merged
@takagi
Copy link
Member Author

takagi commented Feb 21, 2023

/test mini

@takagi
Copy link
Member Author

takagi commented Feb 21, 2023 •
edited

The build-cuda pre-review test failure is due to cuquantum intersphinx inventory error. See #7417

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

This pull request is now in conflicts. Could you fix it @takagi? 🙏

@takagi
Copy link
Member Author

takagi commented Feb 27, 2023

/test mini

@kmaehashi
Copy link
Member

It seems some tests need to be skipped in ROCm as rocSOLVER does not implement several methods.

@takagi
Copy link
Member Author

takagi commented Feb 28, 2023

/test mini

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

This pull request is now in conflicts. Could you fix it @takagi? 🙏

@takagi
Copy link
Member Author

takagi commented Mar 8, 2023

/test mini

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This pull request is now in conflicts. Could you fix it @takagi? 🙏

@emcastillo
Copy link
Member

/test all

@kmaehashi kmaehashi added this to the v13.0.0a1 milestone May 23, 2023
@emcastillo emcastillo added the blocking Issue/pull-request is mandatory for the upcoming release label May 23, 2023
@kmaehashi
Copy link
Member

/test full

@kmaehashi

This comment was marked as outdated.

Sign in to view
@kmaehashi kmaehashi removed the blocking Issue/pull-request is mandatory for the upcoming release label May 23, 2023
@kmaehashi kmaehashi removed this from the v13.0.0a1 milestone May 23, 2023
@kmaehashi
Copy link
Member

Test failures are irrelevant to this PR.

@kmaehashi kmaehashi merged commit 44be13e into cupy:main May 23, 2023
49 of 52 checks passed
@kmaehashi kmaehashi added this to the v13.0.0a1 milestone May 23, 2023
@chainer-ci chainer-ci mentioned this pull request May 23, 2023
Merged
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request May 23, 2023
@kmaehashi @chainer-ci
Merge pull request cupy#7367 from takagi/scipy-1.10
12b320f 
Support SciPy 1.10
@takagi takagi deleted the scipy-1.10 branch May 23, 2023 12:06
@kmaehashi kmaehashi mentioned this pull request Jun 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 asi1024 left review comments

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
Platform Support (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@takagi @kmaehashi @emcastillo @asi1024