Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symiirorder2 to cupyx.scipy.signal #7518

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Add symiirorder2 to cupyx.scipy.signal #7518

merged 6 commits into from
Apr 17, 2023

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Apr 10, 2023

See #7403
Depends on #7511

@andfoy andfoy mentioned this pull request Apr 10, 2023
Open
@kmaehashi kmaehashi added cat:feature New features/APIs prio:medium labels Apr 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@andfoy andfoy force-pushed the add_symiirorder2 branch 3 times, most recently from 1f82ff0 to 8bf65e1 Compare April 13, 2023 02:01
@andfoy andfoy marked this pull request as ready for review April 13, 2023 18:33
@takagi takagi added this to the v13.0.0a1 milestone Apr 17, 2023
@takagi
Copy link
Member

takagi commented Apr 17, 2023

/test mini

takagi
takagi approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit c8bcae4 into cupy:main Apr 17, 2023
4 checks passed
@takagi
Copy link
Member

takagi commented Apr 17, 2023 •
edited

Do you think it makes sense to have performance comparisons on symiirorder1 and symiirorder2 against scipy counterparts? I know both use lfilter; if possible, I'd like to have them in #7511 and #7518 for reference.

@andfoy andfoy deleted the add_symiirorder2 branch April 17, 2023 14:16
@takagi takagi mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:feature New features/APIs prio:medium
Projects
Signal API (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andfoy @takagi @kmaehashi