Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sosfilt_zi to cupyx.scipy.signal #7552

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented May 10, 2023

See #7403
Depends on #7528

This PR is an extension of lfilter_zi, which uses the same principle applied to chained second order sections.

@andfoy andfoy changed the title Add sosfilt zi Add sosfilt_zi to cupyx.scipy.signal May 10, 2023
@kmaehashi kmaehashi added cat:feature New features/APIs prio:medium labels May 11, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@andfoy andfoy marked this pull request as ready for review May 17, 2023 11:28
@takagi
Copy link
Member

takagi commented May 18, 2023

/test mini

@takagi
Copy link
Member

takagi commented May 26, 2023

/test mini

2 similar comments
@takagi
Copy link
Member

takagi commented May 26, 2023

/test mini

@takagi
Copy link
Member

takagi commented May 29, 2023

/test mini

Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit eb921cf into cupy:main Jun 6, 2023
50 checks passed
@takagi
Copy link
Member

takagi commented Jun 6, 2023

Thanks, @andfoy!

@takagi takagi added this to the v13.0.0b1 milestone Jun 6, 2023
@andfoy andfoy deleted the add_sosfilt_zi branch June 6, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants