New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port periodogram, welch and csd from CuSignal to cupyx.signal #7564

Merged

takagi merged 9 commits into cupy:main from andfoy:add_periodogram_welch_csd

Sep 12, 2023

Contributor

andfoy commented May 15, 2023 •

edited

See #7403
Depends on #7563 to ensure that the files do not get merge conflicts
Depends on #7536 to implement csd
Depends on #7568 to implement spectral_analysis, it depends on get_window

This port implies Python-only functions and therefore can be copied 1:1 from the original CuSignal implementation.

andfoy mentioned this pull request

Tracker: cupyx.scipy.signal #7403

Open

andfoy force-pushed the add_periodogram_welch_csd branch from 62a5c71 to 90cb378 Compare

May 15, 2023 13:44

emcastillo assigned takagi

emcastillo added cat:feature prio:medium labels

Contributor

mergify bot commented May 17, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

takagi changed the title ~~Port periodogram, welch and csd from CuSignal to cupyx.signal~~ [DONT MERGE BEFORE LICENSE CLEARANCE] Port periodogram, welch and csd from CuSignal to cupyx.signal

takagi changed the title ~~[DONT MERGE BEFORE LICENSE CLEARANCE] Port periodogram, welch and csd from CuSignal to cupyx.signal~~ [MERGE PENDING] Port periodogram, welch and csd from CuSignal to cupyx.signal

andfoy force-pushed the add_periodogram_welch_csd branch from a3d5a88 to eddeed3 Compare

May 17, 2023 11:48

Member

takagi commented May 19, 2023

/test mini

Contributor

mergify bot commented Jun 2, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch from eddeed3 to f3899d4 Compare

June 8, 2023 08:45

Contributor

mergify bot commented Jun 12, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch 5 times, most recently from 6b7cc01 to f0d79c6 Compare

June 13, 2023 13:48

Member

takagi commented Jun 14, 2023

/test mini

andfoy force-pushed the add_periodogram_welch_csd branch from 2037e2a to 7f173b9 Compare

June 14, 2023 15:32

Member

takagi commented Jun 19, 2023

/test mini

Contributor

mergify bot commented Jun 20, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch from 7f173b9 to bee5b31 Compare

June 21, 2023 18:45

Member

takagi commented Jul 4, 2023

/test full

Contributor

mergify bot commented Jul 10, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch from c898fff to b3b4872 Compare

July 10, 2023 16:12

Contributor

mergify bot commented Jul 12, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch from b3b4872 to 5c1560f Compare

July 12, 2023 16:14

Contributor

mergify bot commented Jul 31, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch from 5c1560f to 1e6796f Compare

August 3, 2023 12:39

Contributor

mergify bot commented Aug 3, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy force-pushed the add_periodogram_welch_csd branch 3 times, most recently from 816e2b4 to a3385a6 Compare

August 30, 2023 17:38

andfoy marked this pull request as ready for review

August 30, 2023 17:39

andfoy changed the title ~~[MERGE PENDING] Port periodogram, welch and csd from CuSignal to cupyx.signal~~ Port periodogram, welch and csd from CuSignal to cupyx.signal

andfoy mentioned this pull request

Port stft/istft from CuSignal to cupyx.scipy.signal #7838

Merged

Contributor

mergify bot commented Sep 4, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

andfoy added 7 commits

September 4, 2023 10:36


          Start porting periodogram, welch and csd

e6d3314


          Add copyright notice

c3e29d4


          Start moving _spectral_helper

0842b28


          Add periodogram tests

57d17ff


          Add welch tests

1d791ef


          Port CSD tests

824e70e


          Expose functions in Sphinx

212a3ba

andfoy force-pushed the add_periodogram_welch_csd branch from a3385a6 to 212a3ba Compare

September 4, 2023 15:37

Member

takagi commented Sep 7, 2023

/test full


          Skip test_copied_data on CUDA 11.x

3f4d887

takagi reviewed

View reviewed changes

cupyx/scipy/signal/_spectral.py Outdated Show resolved Hide resolved


          Update cupyx/scipy/signal/_spectral.py

a90fcac

Member

takagi commented Sep 8, 2023

/test full

takagi added this to the v13.0.0rc1 milestone

takagi approved these changes

View reviewed changes

Member

takagi left a comment

LGTM!

takagi merged commit 5a4c7a1 into cupy:main

46 of 47 checks passed

Member

takagi commented Sep 12, 2023

Thanks, @andfoy!

andfoy deleted the add_periodogram_welch_csd branch

September 12, 2023 13:12

rgommers reviewed

View reviewed changes

cupyx/scipy/signal/_spectral.py

+              Spectral analysis functions and utilities.
+              Some of the functions defined here were ported directly from CuSignal under
+              terms of the Apache license, under the following notice

Contributor

rgommers Mar 31, 2024

@andfoy this info looks incorrect and seems important to fix. cuSignal was explicitly relicensed to MIT in order to facilitate upstreaming into CuPy. See rapidsai/cusignal#587 (comment) and gh-7816.

Could you please open a follow-up PR to address this?

andfoy mentioned this pull request

Replace license notice in cupyx.scipy.signal._spectral #8268

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment