-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix nan value mismatches in filtfilt tests #7567
Conversation
We can only merge this to v12 as CUDA 10.2 is planned to drop in v13. |
Would you move this change on top of |
CUDA 10.2 drop is under RFC in #7557 although no one complained so far. How about skipping these tests for CUDA 10.2 ( cupy/tests/cupyx_tests/scipy_tests/sparse_tests/test_csc.py Lines 1112 to 1114 in 6f135c4
|
/test full |
Thanks, @andfoy! |
@takagi Failed to backport automatically.
|
No need to make a backport. |
After #7496, some failures started to appear in the
cuda102
CIs regardingnan
and zeros mismatches. Since these errors do not appear (and cannot be reproduced) in CIs that run newer CUDA versions, they are most probably related to unstable input coefficients which causelfilter_zi
to benan
, which then when they are applied to a signal that is zero, it will outputnan
as opposed to zero.