Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix nan value mismatches in filtfilt tests #7567

Merged
merged 2 commits into from
May 18, 2023

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented May 16, 2023

After #7496, some failures started to appear in the cuda102 CIs regarding nan and zeros mismatches. Since these errors do not appear (and cannot be reproduced) in CIs that run newer CUDA versions, they are most probably related to unstable input coefficients which cause lfilter_zi to be nan, which then when they are applied to a signal that is zero, it will output nan as opposed to zero.

@asi1024 asi1024 added cat:test Test code / CI prio:high labels May 17, 2023
@takagi takagi added this to the v12.1.0 milestone May 17, 2023
@takagi takagi changed the title Try to fix nan value mismatches in filtfilt tests [v12] Try to fix nan value mismatches in filtfilt tests May 17, 2023
@takagi
Copy link
Member

takagi commented May 17, 2023

We can only merge this to v12 as CUDA 10.2 is planned to drop in v13.

@takagi
Copy link
Member

takagi commented May 17, 2023

Would you move this change on top of v12 branch?

@kmaehashi
Copy link
Member

CUDA 10.2 drop is under RFC in #7557 although no one complained so far. How about skipping these tests for CUDA 10.2 (cupy.cuda.runtime.runtimeGetVersion() == 10020) like we do in

@pytest.mark.skipif(
not runtime.is_hip and cupy.cuda.runtime.runtimeGetVersion() < 8000,
reason='CUDA <8 cannot keep number of non-zero entries ')
, and merge this one to both main/v12 branch?

@takagi takagi changed the title [v12] Try to fix nan value mismatches in filtfilt tests Try to fix nan value mismatches in filtfilt tests May 18, 2023
@takagi takagi modified the milestones: v12.1.0, v13.0.0a1 May 18, 2023
@takagi
Copy link
Member

takagi commented May 18, 2023

/test full

@takagi takagi added the to-be-backported Pull-requests to be backported to stable branch label May 18, 2023
@takagi takagi merged commit 37894c1 into cupy:main May 18, 2023
50 of 52 checks passed
@takagi
Copy link
Member

takagi commented May 18, 2023

Thanks, @andfoy!

@chainer-ci
Copy link
Member

@takagi Failed to backport automatically.


Not cleanly cherry-picked

@takagi takagi removed the to-be-backported Pull-requests to be backported to stable branch label May 18, 2023
@takagi
Copy link
Member

takagi commented May 18, 2023

No need to make a backport.

@andfoy andfoy deleted the fix_filtfilt_test branch May 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test code / CI prio:high
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants