Fix _depends.json not included in wheel
#7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
force-pushed
the
fix-windows-dll-depends
branch
from
a90351d
to
07472e0
Compare
|
/test mini |
|
Q: Is this something that we should also include in the conda package? |
|
/test mini |
kmaehashi
added
to-be-backported
It's nice to have. CuPy ignores it silently if it is missing. This PR let |
|
Test failure is irrelevant. |
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
May 23, 2023
Fix `_depends.json` not included in wheel
3 tasks
1 task
Confirmed: conda-forge/cupy-feedstock#218 (comment) |
|
Thanks for checking, Leo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature added in #7279 was not working in shipped wheels as the
_depends.jsonfile is not included in the wheel.c.f. pypa/setuptools#1064