Fix flake8-cython not working #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
commented
Jun 2, 2023
| @@ -1,4 +1,4 @@ | |||
| [flake8] | |||
| filename = *.pyx, *.pxd, *.pxi | |||
| exclude = .git, .eggs, *.py | |||
| ignore = W503,W504,E225,E226,E227,E402,E999 | |||
| ignore = W503,W504,E225,E226,E227,E275,E402,E999 | |||
There was a problem hiding this comment.
E275 is to silence errors at except? (missing whitespace after keyword).
kmaehashi
force-pushed
the
fix-flake8-cython
branch
from
8b2abcd
to
094c089
Compare
emcastillo
added
cat:other
emcastillo
approved these changes
Jun 2, 2023
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Jun 2, 2023
Fix flake8-cython not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had to be in #7595 to enable flake8 lint against Cython.
I think these config can be removed after a certain period of time, once #7508 got merged.