cupyx/scipy.signal: port *ord filter design functions from scipy.signal #7632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
added a commit
to ev-br/cupy
that referenced
this pull request
Jun 15, 2023
These are fixed up and included in cupy#7632
ev-br
force-pushed
the
ord_funcs
branch
3 times, most recently
from
0db80b4
to
db46a78
Compare
3 tasks
takagi
reviewed
Jun 19, 2023
| w, h = scp.signal.sosfreqz(sos) | ||
| return w, h | ||
|
|
||
| @testing.with_requires("mpmath > 0.10") |
There was a problem hiding this comment.
I'll make another PR to make CI install mpmath.
|
/test mini |
|
Rebased on main, now that gh-7537 is in. |
|
I'll kick the CI after #7653 is merged. |
|
/test full |
Just copy-pasted from scipy. This implementation is pure python and thus horribly inefficient.
|
/test full |
takagi
reviewed
Jun 30, 2023
|
/test full |
|
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
takagi
approved these changes
Jul 4, 2023
|
/test full |
|
CI failures are not related. |
|
Thanks, @ev-br! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-ref gh-7403
Port order selection functions for several types of filters
.
cupyx.scipy.signal._optimizemoduleThis PR is on top of gh-7537