add kaiser{ord,_beta,_atten} functions #7635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test mini |
|
Rebased on main. |
|
/test full |
takagi
reviewed
Jun 27, 2023
|
/test full |
takagi
previously approved these changes
Jun 27, 2023
|
/test full |
|
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
|
/test full |
|
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
|
/test full |
|
/test mini |
|
For record: These functions take Python scalars and return them as well, where computing on CPU is enough. An option is depending on SciPy then having aliases to it, but here we're independent of SciPy and have the same ones on CuPy. |
|
CI failures are not related. |
|
Thanks, @ev-br! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-ref #7403
Add
on top of gh-7537