Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add cupyx.scipy.signal.minimum_phase #7638

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented Jun 16, 2023

cross-ref #7403

This PR is on top of gh-7537 to minimize git conflicts going forward.

@takagi
Copy link
Member

takagi commented Jun 20, 2023

/test mini

takagi
takagi previously approved these changes Jun 20, 2023
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ev-br ev-br dismissed takagi’s stale review June 20, 2023 05:05

The merge-base changed after approval.

@ev-br
Copy link
Contributor Author

ev-br commented Jun 20, 2023

Rebased on main.

@takagi takagi added this to the v13.0.0b1 milestone Jun 21, 2023
@takagi
Copy link
Member

takagi commented Jun 21, 2023

I'll kick the CI once #7653 is merged.

@takagi
Copy link
Member

takagi commented Jun 23, 2023

/test full

Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI failures are not related to this. I filed #7665.

@takagi takagi merged commit aa4f73e into cupy:main Jun 26, 2023
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants