Avoid using numpy.find_common_type
#7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Jun 20, 2023
cupy/_indexing/generate.py
Outdated
|
|
||
| final_dtype = numpy.find_common_type(arraytypes, scalartypes) | ||
| final_dtype = numpy.result_type(*key) |
There was a problem hiding this comment.
Thanks, changes look good! This one, I suspect this is slightly more complicated because key can include slice objects. I am happy to also make a PR (was going to look into it later). The change I did in NumPy is here:
There was a problem hiding this comment.
Thanks! We don't support slice objects here so it should be OK for now 😄
cupy/cupy/_indexing/generate.py
Lines 49 to 50 in c5153de
asi1024
added
to-be-backported
|
/test mini |
kmaehashi
previously approved these changes
Aug 10, 2023
|
@asi1024 Could you check test failures? 🙏 |
|
/test mini |
asi1024
force-pushed
the
deprecate-find_common_types
branch
from
f2b5351
to
9cc8dc2
Compare
|
/test mini |
|
@kmaehashi Ready to review! |
kmaehashi
approved these changes
Aug 17, 2023
|
Test failures are irrelevant. |
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 17, 2023
Avoid using `numpy.find_common_type`
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.find_common_typehas been deprecated in NumPy 1.25.