Update pylibcugraph weakly connected components call #7693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asi1024
added
cat:bug
|
Thank you! Let me bump up the RAPIDS version for CI in this PR. |
|
/test rapids |
|
/test rapids |
kmaehashi
approved these changes
Jul 7, 2023
|
@kmaehashi Failed to backport automatically. |
kmaehashi
added a commit
to kmaehashi/cupy
that referenced
this pull request
Jul 7, 2023
Update pylibcugraph weakly connected components call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking
pylibcugraphPR updated the function signature of weakly connected components thereby breaking the weak connection of CuPyconnected components. Furthermore, bothpylibcugraphstrongly and weakly connected components no longer returns ordered labels and the starting value is now 0.This PR updates the
pylibcugraph.weakly_connected_componentscall in cupyconnected_componentsalong with the tests to always adjust labels since in most cases, the labels returned by both CuPy and SciPy are un-ordered.closes #7672