Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates for cuQuantum/cuTensorNet support #7723

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Minor updates for cuQuantum/cuTensorNet support #7723

merged 3 commits into from
Jul 18, 2023

Conversation

leofang
Copy link
Member

@leofang leofang commented Jul 14, 2023 •
edited

  1. Update link to cuQuantum docs (the old link will soon be invalidated!)
  2. Restore cupy.einsum()'s async behavior when dispatching to cuTensorNet
  3. Support computing trace ii-> with cuTensorNet
    • I still see issues with general singleton expressions, so I disable it for now
  4. Support multi-threading (each thread will use its own handle)
  5. Fix leaking the handle at shutdown

Recall that currently the CI does not test this integration, so manual testing is still required:

pip install cuquantum-python-cu11  # or -cu12 for CUDA 12
CUPY_ACCELERATORS=cub,cutensornet pytest tests/cupy_tests/linalg_tests/test_einsum.py

Please kindly backport this PR, thanks! 馃槄

@leofang
Copy link
Member Author

leofang commented Jul 14, 2023

xref: NVIDIA/MatX#447 (thanks @cliffburdick for reminding me about this 馃檪)

cc: @yangcal for vis

@emcastillo emcastillo self-assigned this Jul 14, 2023
@emcastillo emcastillo added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch prio:medium labels Jul 14, 2023
@leofang leofang changed the title WIP: Minor updates for cuQuantum/cuTensorNet support Minor updates for cuQuantum/cuTensorNet support Jul 17, 2023
@leofang leofang marked this pull request as ready for review July 17, 2023 15:08
@leofang
Copy link
Member Author

leofang commented Jul 17, 2023

/test mini

emcastillo
emcastillo approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emcastillo emcastillo merged commit 238374c into cupy:main Jul 18, 2023
48 checks passed
@emcastillo emcastillo added this to the v13.0.0b1 milestone Jul 18, 2023
@chainer-ci chainer-ci mentioned this pull request Jul 18, 2023
Merged
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jul 18, 2023
@chainer-ci
Merge pull request cupy#7723 from leofang/cuqnt_update
0542a18 
Minor updates for cuQuantum/cuTensorNet support
@leofang leofang deleted the cuqnt_update branch July 18, 2023 10:52
lcskrishna pushed a commit to lcskrishna/cupy that referenced this pull request Jul 27, 2023
@lcskrishna
Merge pull request cupy#7723 from leofang/cuqnt_update
c0f81c7 
Minor updates for cuQuantum/cuTensorNet support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcastillo emcastillo emcastillo approved these changes

Assignees

@emcastillo emcastillo

Labels
cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v13.0.0b1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leofang @emcastillo