Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csr2dense to avoid race conditions #7724

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jul 14, 2023

Close #7713.

@emcastillo emcastillo self-assigned this Jul 18, 2023
@emcastillo emcastillo added cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch labels Jul 18, 2023
@asi1024
Copy link
Member Author

asi1024 commented Jul 20, 2023

CuPy does not currently support bool sparse matrix officially, and not tested.

@asi1024 asi1024 marked this pull request as ready for review July 20, 2023 12:21
@emcastillo
Copy link
Member

/test mini

@emcastillo emcastillo merged commit fd54d95 into cupy:main Aug 16, 2023
54 checks passed
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Aug 16, 2023
Fix csr2dense to avoid race conditions
@asi1024 asi1024 deleted the fix-todense branch August 16, 2023 01:33
@asi1024 asi1024 added this to the v13.0.0rc1 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cupyx.scipy.sparse.csr_matrix of dtype bool behaves different from scipy.sparse.csr_matrix
2 participants