Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stream kwonly argument in ndarray.__dlpack__ #7829

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Make stream kwonly argument in ndarray.__dlpack__ #7829

merged 1 commit into from
Aug 30, 2023

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Aug 28, 2023

For NumPy compatibility.

@asi1024 asi1024 added no-compat Disrupts backward compatibility cat:numpy-compat Follow the NumPy/SciPy spec changes labels Aug 28, 2023
leofang
leofang approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @asi1024!

xref: https://data-apis.org/array-api/2022.12/API_specification/generated/array_api.array.__dlpack__.html

@leofang
Copy link
Member

leofang commented Aug 28, 2023

/test mini

@kmaehashi
Copy link
Member

@asi1024 Please check test failures that directly calling __dlpack__.

@kmaehashi kmaehashi self-assigned this Aug 29, 2023
@asi1024
Copy link
Member Author

asi1024 commented Aug 29, 2023

/test mini

@kmaehashi kmaehashi merged commit ee8394c into cupy:main Aug 30, 2023
45 of 46 checks passed
@kmaehashi kmaehashi added this to the v13.0.0rc1 milestone Aug 30, 2023
@asi1024 asi1024 deleted the dlpack_kwonly branch August 30, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:numpy-compat Follow the NumPy/SciPy spec changes no-compat Disrupts backward compatibility prio:medium
Projects
None yet
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asi1024 @leofang @kmaehashi