Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port decimate, resample and resample_poly from CuSignal to cupyx.scipy.signal #7855

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Port decimate, resample and resample_poly from CuSignal to cupyx.scipy.signal #7855

merged 5 commits into from
Oct 14, 2023

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Sep 7, 2023

See #7403
Depends on #7749

@andfoy andfoy mentioned this pull request Sep 7, 2023
Open
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@kmaehashi kmaehashi added cat:feature New features/APIs prio:medium labels Sep 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@andfoy andfoy marked this pull request as ready for review October 4, 2023 02:12
@asi1024 asi1024 added this to the v13.0.0rc1 milestone Oct 4, 2023
@takagi
Copy link
Member

takagi commented Oct 4, 2023 •
edited

Would you add these APIs to signal.rst?

@takagi
Copy link
Member

takagi commented Oct 4, 2023

/test full

@takagi
Copy link
Member

takagi commented Oct 5, 2023

The following is the result of the fulltest, and it seems that combinations with older scipy have failures.
https://ci.preferred.jp/p/dashboard_by_commit_id?commit_id=3f979f2e8a2e3bee09854efc76df3581ebaf2d24

FAILED cupyx_tests/scipy_tests/signal_tests/test_resample.py::TestDecimate::test_long_float32
FAILED cupyx_tests/scipy_tests/signal_tests/test_resample.py::TestDecimate::test_float16_upcast

Would you skip these tests for older scipy? I think scipy>=1.10 works with these.

@takagi
Copy link
Member

takagi commented Oct 13, 2023

/test full

takagi
takagi approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit 8ddb02d into cupy:main Oct 14, 2023
47 checks passed
@takagi
Copy link
Member

takagi commented Oct 14, 2023

Thanks, @andfoy!

@andfoy andfoy deleted the add_decimate_resample branch October 14, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:feature New features/APIs prio:medium
Projects
Signal API (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andfoy @takagi @kmaehashi @asi1024