Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scipy.linalg.{tri/tril/triu} are deprecated in SciPy 1.11.0 #7889

Merged
merged 2 commits into from
Oct 4, 2023
Merged

scipy.linalg.{tri/tril/triu} are deprecated in SciPy 1.11.0 #7889

merged 2 commits into from
Oct 4, 2023

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Sep 29, 2023 •
edited

@takagi takagi self-assigned this Oct 2, 2023
@takagi takagi added cat:numpy-compat Follow the NumPy/SciPy spec changes blocking Issue/pull-request is mandatory for the upcoming release prio:high to-be-backported Pull-requests to be backported to stable branch labels Oct 2, 2023
@takagi
Copy link
Member

takagi commented Oct 2, 2023

to-be-backport is for test code only.

@takagi takagi added this to the v13.0.0rc1 milestone Oct 2, 2023
@takagi takagi enabled auto-merge October 2, 2023 05:21
takagi
takagi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi
Copy link
Member

takagi commented Oct 2, 2023

/test head

@asi1024
Copy link
Member Author

asi1024 commented Oct 2, 2023

https://ci.preferred.jp/cupy.linux.cuda-head/144697/

takagi
takagi approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi
Copy link
Member

takagi commented Oct 4, 2023

{tri/tril/triu} test failures are gone in the head test.

@takagi takagi disabled auto-merge October 4, 2023 02:34
@takagi takagi merged commit bb20566 into cupy:main Oct 4, 2023
41 of 58 checks passed
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Oct 4, 2023
@takagi @chainer-ci
Merge pull request cupy#7889 from asi1024/deprecate-scipy-tri
ca0ad36 
`scipy.linalg.{tri/tril/triu}` are deprecated in SciPy 1.11.0
@chainer-ci chainer-ci mentioned this pull request Oct 4, 2023
Merged
@asi1024 asi1024 deleted the deprecate-scipy-tri branch October 4, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
blocking Issue/pull-request is mandatory for the upcoming release cat:numpy-compat Follow the NumPy/SciPy spec changes prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
Platform Support (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asi1024 @takagi