Ensure D2H copies are stream ordered and by default blocking #7938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test mini |
|
Thank you Leo! |
kmaehashi
reviewed
Oct 16, 2023
leofang
added
the
blocking
|
(btw I tagged this PR with "blocking" since this is a "no-compat" change.) |
leofang
commented
Oct 17, 2023
|
/test mini |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7820.
As discussed in the linked issue, this PR adds a new, optional argument
blockingto control the copy behavior, and make it default toTrueto avoid data race. A test that can easily expose the data race is added.Note that during the discussion, it was proposed to name the new argument as
async. However,asyncis a reserved Python keyword (for coroutines), so I changed it toblocking, but I am happy to make changes if requested.