Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ast expr in CuPy JIT #7941

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove deprecated ast expr in CuPy JIT #7941

merged 1 commit into from
Oct 18, 2023

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Oct 17, 2023 •
edited by kmaehashi

ast.Num, ast.Str and ast.NameConstant are deprecated since Python 3.8, and raise DeprecationWarning since Python Python 3.12. Part of #7899.

@asi1024 asi1024 added the cat:code-fix Code refactoring that do not change behavior label Oct 17, 2023
@asi1024 asi1024 mentioned this pull request Oct 17, 2023
Merged
@kmaehashi
Copy link
Member

/test mini

@kmaehashi kmaehashi self-assigned this Oct 18, 2023
@kmaehashi kmaehashi added this to the v13.0.0rc1 milestone Oct 18, 2023
@asi1024 asi1024 added blocking Issue/pull-request is mandatory for the upcoming release prio:high to-be-backported Pull-requests to be backported to stable branch labels Oct 18, 2023
@kmaehashi kmaehashi merged commit 9ac9c06 into cupy:main Oct 18, 2023
55 checks passed
@chainer-ci chainer-ci mentioned this pull request Oct 18, 2023
Merged
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Oct 18, 2023
@kmaehashi @chainer-ci
Merge pull request cupy#7941 from asi1024/jit-deprecated-expr
d78465f 
Remove deprecated ast expr in CuPy JIT
@asi1024 asi1024 deleted the jit-deprecated-expr branch October 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels
blocking Issue/pull-request is mandatory for the upcoming release cat:code-fix Code refactoring that do not change behavior prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asi1024 @kmaehashi