Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings in ndimage kernel generation code #8311

Merged
merged 2 commits into from
May 1, 2024

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 28, 2024

This MR backports a limited number of style changes made for cuCIM's vendored copy of ndimage code. It is intended to improve readability and ease maintenance of the CUDA kernels used by cupyx.scipy.ndimage.

This is split out from other formatting changes in #8126

@takagi takagi self-assigned this Apr 30, 2024
@takagi takagi added prio:medium cat:code-fix Code refactoring that do not change behavior labels Apr 30, 2024
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Waiting for CI finish.

@takagi takagi enabled auto-merge April 30, 2024 04:40
@takagi takagi added this to the v14.0.0a1 milestone Apr 30, 2024
@takagi
Copy link
Member

takagi commented May 1, 2024

/test mini

@takagi takagi merged commit a384b1a into cupy:main May 1, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that do not change behavior prio:medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants