ndimage: more efficient testing of binary morphology functions #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test mini |
|
This pull request is now in conflicts. Could you fix it @grlee77? 🙏 |
split fully dense product into separate products that test different aspects with less redundancy This change reduced the number of binary morphology tests cases from 4118 to 476
auto-merge was automatically disabled
May 1, 2024 11:40
Head branch was pushed to by a user without write access
grlee77
force-pushed
the
ndimage-reduce-binary-morphology-test-cases
branch
from
4f263dd
to
1070901
Compare
|
conflicts have been resolved, please retest |
|
/test mini |
takagi
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this MR is to refactor existing binary morphology tests from a single dense product over all parameters to 2 or 3 products over a small subset of the parameters. The functionality tested should be equivalent while reducing the total number of test cases run by an order of magnitude.
When running the morphology tests with
pytestflag-k Binary, the number of tests that run is reduced from 4054 (before) to 412 (after).