Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cupyx: cleanup use of deprecated NumPy functionality (NumPy 2.0 compatibility) #8320

Merged
merged 4 commits into from
May 13, 2024

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented May 4, 2024

This MR has some minor housekeeping changes, mostly in cupyx.scipy modules so they are not using functionality deprecated for NumPy 2.0.

This should complement the changes being made by @ev-br in #8314

related to #8306

@kmaehashi kmaehashi added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch prio:medium labels May 7, 2024
@takagi
Copy link
Member

takagi commented May 9, 2024

/test mini

@takagi takagi added this to the v14.0.0a1 milestone May 9, 2024
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit ba8def1 into cupy:main May 13, 2024
60 checks passed
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request May 13, 2024
cupyx: cleanup use of deprecated NumPy functionality (NumPy 2.0 compatibility)
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants