Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batched solve_triangular #8329

Merged
merged 7 commits into from
May 31, 2024
Merged

Add batched solve_triangular #8329

merged 7 commits into from
May 31, 2024

Conversation

Berrysoft
Copy link
Contributor

It is not implemented in scipy, but I need it for my research:)

@takagi
Copy link
Member

takagi commented May 23, 2024

/test mini

@takagi
Copy link
Member

takagi commented May 23, 2024

/test mini

@takagi
Copy link
Member

takagi commented May 29, 2024

/test mini

Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Berrysoft, thanks for the contribution! We usually keep our APIs compatible with SciPy ones but this sounds good addition without any breakage.

cupyx/scipy/linalg/_solve_triangular.py Show resolved Hide resolved
Co-authored-by: Kenichi Maehashi <939877+kmaehashi@users.noreply.github.com>
@Berrysoft
Copy link
Contributor Author

The hip used by CI seems different from mine. I'll fix it later.

@Berrysoft Berrysoft requested a review from kmaehashi May 29, 2024 19:03
@takagi
Copy link
Member

takagi commented May 30, 2024

/test mini

@Berrysoft
Copy link
Contributor Author

The CI failed, but it seems not my fault:

C:\Windows\TEMP\flexci\run-00332685\tmp\tmpkmrn5qje\a.cpp(1): fatal error C1083: Cannot open include file: 'nccl.h': No such file or directory

Same error message for "cutensor.h" and "cusparseLt.h".

@takagi
Copy link
Member

takagi commented May 31, 2024

@takagi
Copy link
Member

takagi commented May 31, 2024

The failure seems not to be related.

Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit d8df1f0 into cupy:main May 31, 2024
7 checks passed
@Berrysoft Berrysoft deleted the batched-trsm branch May 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants