Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: fft, linalg: add __all__ lists #8333

Merged
merged 2 commits into from
May 29, 2024
Merged

MAINT: fft, linalg: add __all__ lists #8333

merged 2 commits into from
May 29, 2024

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented May 22, 2024

Otherwise, all array API implementors resort to exec via array_api_compat: https://github.com/data-apis/array-api-compat/blob/main/array_api_compat/cupy/fft.py#L2

@ev-br ev-br changed the title MAINT: fft: add __all__ list MAINT: fft, linalg: add __all__ lists May 22, 2024
@takagi takagi self-assigned this May 23, 2024
@takagi takagi added cat:enhancement Improvements to existing features prio:medium labels May 23, 2024
@takagi
Copy link
Member

takagi commented May 29, 2024

/test mini

takagi
takagi approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Waiting for CI pass.

@takagi takagi enabled auto-merge May 29, 2024 04:27
@takagi takagi merged commit 1fd765f into cupy:main May 29, 2024
59 checks passed
@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:enhancement Improvements to existing features prio:medium
Projects
None yet
Milestone
v14.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ev-br @takagi @kmaehashi