Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Docker update information to upgrade guide #993

Merged
merged 1 commit into from Mar 5, 2018

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Feb 26, 2018

For change introduced in #991.

The same sentence as in Chainer upgrade guide.
https://github.com/chainer/chainer/blob/v4.0.0b4/docs/source/upgrade.rst#update-of-docker-images

@kmaehashi kmaehashi added this to the v4.0.0rc1 milestone Feb 26, 2018
@kmaehashi kmaehashi added the cat:document Documentation label Feb 26, 2018
@mitmul
Copy link
Member

mitmul commented Feb 26, 2018

The test is failing due to numerical error. Jenkins, test this please.

@okuta okuta added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 1, 2018
@okuta okuta self-assigned this Mar 1, 2018
@okuta
Copy link
Member

okuta commented Mar 1, 2018

I will merge this PR.

@okuta
Copy link
Member

okuta commented Mar 5, 2018

LGTM!

@okuta okuta merged commit 7b09f74 into cupy:master Mar 5, 2018
@kmaehashi kmaehashi deleted the upgrade-guide-docker branch March 5, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants