Support Publish in batch using generic BatchTasks
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 5, 2017 13:41
`BatchesController#create` supports creating generic batches via the `BatchTask` batchable.
no-reply
force-pushed
the
feature/batch-publish
branch
from
432d187
to
0d49cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a generic
BatchTaskto serve as a batchable linking a batch type to a job class, and supporting enqueueing the appropriate jobs for the batch.A matching controller is introduced to handle creation of generic batches.
TemplateUpdateis still handled byTemplateUpdateController, due to its special parameters.The
PublishJobenqueued by the batch publish button simply calls#mark_publishedon theActiveFedoramodel; that method does not yet exist, pending #5.