Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate admin sets #131

Merged
merged 6 commits into from
May 9, 2017
Merged

Automate admin sets #131

merged 6 commits into from
May 9, 2017

Conversation

bess
Copy link

@bess bess commented May 4, 2017

Addresses #79
This uses an initializer to create four AdminSets, and give them each the one step mediated deposit workflow. These admin sets are owned by a fake user, "uberadmin@localhost.com" whose password is hardcoded. Obviously we'll need to change that when we have shibboleth auth working, but I think the mechanism is good.

bess added 5 commits May 4, 2017 17:04
Automate setup of uberadmin, admin sets, and workflow
loading as much as possible.
Make it clear that workflows are attached to a specific admin set.
…ke uberadmin user, will exist every time you boot the application
@bess bess force-pushed the automate_admin_sets branch 2 times, most recently from 7c23e92 to a1a2b02 Compare May 4, 2017 22:01
Run db:setup and db:migrate before CI tests
Fix rubocop offense
Only run workflow initializer in dev and prod environments
@coveralls
Copy link

coveralls commented May 5, 2017

Coverage Status

Coverage decreased (-0.5%) to 90.311% when pulling 09f266a on automate_admin_sets into c805e0e on master.

@bess bess requested a review from mark-dce May 5, 2017 00:40
@bess
Copy link
Author

bess commented May 5, 2017

@mark-dce Does this fulfill what you were looking for in terms of AdminSet setup?

  • it runs via an initializer, so you don't have to remember to run it
  • it will run whenever the app is started
  • it will ensure these four AdminSets exist and have the mediated deposit workflow, but it won't overwrite any other AdminSets that have been created

Note that coverage went down because I added some lines to ability.rb which are required for the use of hydra-role-management. I don't consider this code that needs a test, but it did drop the overall code coverage number.

@bess bess requested a review from jenlindner May 5, 2017 19:40
@mark-dce mark-dce merged commit e09436a into master May 9, 2017
@mark-dce mark-dce deleted the automate_admin_sets branch May 9, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants