-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize locale labels #154
Conversation
…into supplemental_files Merging
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple things I think we need to add.
@@ -5,6 +5,6 @@ es: | |||
select_type: | |||
etd: | |||
# TODO: translate `human_name` into Spanish | |||
name: "Etd" | |||
name: "ETD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the Spanish description, should this be TDE?
copyright_html: "<strong>Copyright © 2017 Project Hydra</strong> Licensed under the Apache License, Version 2.0" | ||
service_html: A service of <a href="http://projecthydra.org/" class="navbar-link" target="_blank">Project Hydra</a>. | ||
copyright_html: "<strong>Copyright © 2017 Emory University</strong> Licensed under the Apache License, Version 2.0" | ||
service_html: A service of <a href="http://projecthydra.org/" class="navbar-link" target="_blank">Emory University</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the URL too.
copyright_html: "<strong>Copyright © 2017 Proyecto Hydra</strong> bajo licencia de Apache, Version 2.0" | ||
service_html: Un servicio de <a href="http://projecthydra.org/" class="navbar-link" target="_blank">Proyecto Hydra</a>. | ||
copyright_html: "<strong>Copyright © 2017 Emory Universidad</strong> bajo licencia de Apache, Version 2.0" | ||
service_html: Un servicio de <a href="http://projecthydra.org/" class="navbar-link" target="_blank">Emory Universidad</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the URL here.
No description provided.