Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fix for school selection #1877

Merged
merged 1 commit into from Mar 19, 2019
Merged

Additional fix for school selection #1877

merged 1 commit into from Mar 19, 2019

Conversation

little9
Copy link
Contributor

@little9 little9 commented Mar 18, 2019

The check for determining if you were on the
edit screen or submission screen was wrong.

This changes that code so that the check is correct.

Also includes a system spec for creating an ETD with the
new UI.

Connected to #1869

@little9 little9 force-pushed the fix/school-selection branch 3 times, most recently from ac201b9 to a5965bb Compare March 18, 2019 20:34
Copy link

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

The check for determining if you were on the
edit screen or submission screen was wrong.

This changes that code so that the check is correct.

Also includes a system spec for creating an ETD with the
new UI.

Connected to #1869
@little9 little9 merged commit e76aee8 into master Mar 19, 2019
@little9 little9 deleted the fix/school-selection branch March 19, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants