Add simplecov for formatting and ignoring files for test coverage #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-dce
reviewed
Mar 2, 2021
bin/rails
Outdated
| @@ -1,4 +1,10 @@ | |||
| #!/usr/bin/env ruby | |||
| if ENV['RAILS_ENV'] == 'test' | |||
| require 'simplecov' | |||
| SimpleCov.start 'rails' | |||
There was a problem hiding this comment.
I don't know that we're always invoking things via binstubs - would it make sense to move this to the rails helper - i.e. see the pattern here: RepoCamp/ascteam2@8eeb14a
There was a problem hiding this comment.
Aaaah, ok, I was over-generalizing from step 2 here but I think you're right - https://github.com/simplecov-ruby/simplecov#getting-started
- save coverage to same directory as rspec tests in junit formatting - will hopefully allow for combining test coverage results
fnibbit
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.